[coreboot] [commit] r5503 - trunk

repository service svn at coreboot.org
Mon Apr 26 14:27:18 CEST 2010

Author: stepan
Date: Mon Apr 26 14:27:18 2010
New Revision: 5503
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5503

For the mainboard with AMD Family 10, if we make clean and make again,
it will fail. why?

After make clean, .c files created by iasl are still left in the build
folder, it will match the rule of
	$(obj)/%.o: $(obj)/%.c $(obj)/config.h
		@printf "    CC         $(subst $(obj)/,,$(@))\n"
		$(CC) -MMD $(CFLAGS) -c -o $@ $<
it will miss the rule which should be applied.
	define objs_asl_template

So we move the .c file back to .hex (or other suffix? or delete?).
This patch will work after make distclean, otherwise nobody will rename
the .c.

Signed-off-by: Zheng Bao <zheng.bao at amd.com>

Acked-by: Stefan Reinauer <stepan at coresystems.de>


Modified: trunk/Makefile
--- trunk/Makefile	Mon Apr 26 14:08:51 2010	(r5502)
+++ trunk/Makefile	Mon Apr 26 14:27:18 2010	(r5503)
@@ -226,6 +226,8 @@
 	iasl -p $$(basename $$@) -tc $$(basename $$@).asl
 	mv $$(basename $$@).hex $$(basename $$@).c
 	$(CC) $$(CFLAGS) $$(if $$(subst dsdt,,$$(basename $$(notdir $$@))), -DAmlCode=AmlCode_$$(basename $$(notdir $$@))) -c -o $$@ $$(basename $$@).c
+	# keep %.o: %.c rule from catching the temporary .c file after a make clean
+	mv $$(basename $$@).c $$(basename $$@).hex
 # macro to define template macros that are used by use_template macro

More information about the coreboot mailing list