[coreboot] [commit] r5425 - in trunk/src: cpu/amd/model_lx drivers/ati/ragexl mainboard/bcom/winnetp680 mainboard/digitallogic/msm800sev mainboard/hp/dl145_g3 mainboard/kontron/kt690 mainboard/pcengines/alix1...

repository service svn at coreboot.org
Wed Apr 14 12:12:23 CEST 2010


Author: stepan
Date: Wed Apr 14 12:12:23 2010
New Revision: 5425
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5425

Log:
zero warnings days. Down to under 600 different warnings 
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>

Modified:
   trunk/src/cpu/amd/model_lx/vsmsetup.c
   trunk/src/drivers/ati/ragexl/xlinit.c
   trunk/src/mainboard/bcom/winnetp680/romstage.c
   trunk/src/mainboard/digitallogic/msm800sev/romstage.c
   trunk/src/mainboard/hp/dl145_g3/mptable.c
   trunk/src/mainboard/kontron/kt690/mainboard.c
   trunk/src/mainboard/pcengines/alix1c/romstage.c
   trunk/src/mainboard/technexion/tim8690/mainboard.c
   trunk/src/northbridge/amd/amdht/h3finit.c
   trunk/src/northbridge/amd/gx2/northbridge.c
   trunk/src/northbridge/via/vt8623/northbridge.c
   trunk/src/northbridge/via/vx800/dev_init.c
   trunk/src/northbridge/via/vx800/dram_init.c
   trunk/src/northbridge/via/vx800/dram_init.h
   trunk/src/northbridge/via/vx800/drdy_bl.c
   trunk/src/northbridge/via/vx800/freq_setting.c
   trunk/src/northbridge/via/vx800/raminit.c
   trunk/src/northbridge/via/vx800/rank_map.c
   trunk/src/northbridge/via/vx800/uma_ram_setting.c
   trunk/src/northbridge/via/vx800/vgabios.c
   trunk/src/southbridge/amd/cs5535/cs5535_early_setup.c
   trunk/src/southbridge/amd/cs5536/cs5536_smbus2.h
   trunk/src/southbridge/intel/i82801ex/i82801ex_early_smbus.c
   trunk/src/southbridge/nvidia/mcp55/mcp55_early_setup_car.c
   trunk/src/southbridge/nvidia/mcp55/mcp55_fadt.c
   trunk/src/southbridge/via/vt8235/vt8235.c

Modified: trunk/src/cpu/amd/model_lx/vsmsetup.c
==============================================================================
--- trunk/src/cpu/amd/model_lx/vsmsetup.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/cpu/amd/model_lx/vsmsetup.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -268,10 +268,7 @@
 
 void do_vsmbios(void)
 {
-	device_t dev;
-	unsigned long busdevfn;
 	unsigned char *buf;
-	unsigned int size = SMM_SIZE * 1024;
 	int i;
 
 	printk(BIOS_ERR, "do_vsmbios\n");

Modified: trunk/src/drivers/ati/ragexl/xlinit.c
==============================================================================
--- trunk/src/drivers/ati/ragexl/xlinit.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/drivers/ati/ragexl/xlinit.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -489,7 +489,10 @@
     	int j;
     	u16 type;
         u8 rev;
-    	const char *chipname = NULL, *xtal;
+    	const char *chipname = NULL;
+#if CONFIG_CONSOLE_BTEXT
+	const char *xtal;
+#endif
     	int pll, mclk, xclk;
 
 #if CONFIG_CONSOLE_BTEXT==1

Modified: trunk/src/mainboard/bcom/winnetp680/romstage.c
==============================================================================
--- trunk/src/mainboard/bcom/winnetp680/romstage.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/bcom/winnetp680/romstage.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -39,10 +39,6 @@
 #include "superio/winbond/w83697hf/w83697hf_early_serial.c"
 #define SERIAL_DEV PNP_DEV(0x2e, W83697HF_SP1)
 
-static void memreset_setup(void)
-{
-}
-
 static inline int spd_read_byte(unsigned device, unsigned address)
 {
 	return smbus_read_byte(device, address);
@@ -53,8 +49,6 @@
 static void enable_mainboard_devices(void)
 {
 	device_t dev;
-	u8 reg;
- 
 	dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VT8237R_LPC), 0);
 	if (dev == PCI_DEV_INVALID)
 		die("Southbridge not found!!!\n");
@@ -89,9 +83,6 @@
 
 void main(unsigned long bist)
 {
-	unsigned long x;
-	device_t dev;
-
 	/* Enable multifunction for northbridge. */
 	pci_write_config8(ctrl.d0f0, 0x4f, 0x01);
 

Modified: trunk/src/mainboard/digitallogic/msm800sev/romstage.c
==============================================================================
--- trunk/src/mainboard/digitallogic/msm800sev/romstage.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/digitallogic/msm800sev/romstage.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -51,7 +51,6 @@
 	msr.hi = 0x20000000;
 	msr.lo =  0xfff00;
 	wrmsr(MSR_GLIU1 + 0x20, msr);
-
 }
 
 static void mb_gpio_init(void)
@@ -61,7 +60,6 @@
 
 void cache_as_ram_main(void)
 {
-	extern void RestartCAR();
 	post_code(0x01);
 
 	static const struct mem_controller memctrl [] = {

Modified: trunk/src/mainboard/hp/dl145_g3/mptable.c
==============================================================================
--- trunk/src/mainboard/hp/dl145_g3/mptable.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/hp/dl145_g3/mptable.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -50,8 +50,6 @@
 	static const char productid[12] = "TREX        ";
 	struct mp_config_table *mc;
 
-	unsigned char bus_num;
-	int i;
 	struct mb_sysconf_t *m;
 
 	mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
@@ -78,11 +76,13 @@
 
 	/*Bus:         Bus ID  Type*/
 	/* define bus and isa numbers */
-/*	for(bus_num = 0; bus_num < m->bus_isa; bus_num++) {
+#if 0
+	unsigned char bus_num;
+	for(bus_num = 0; bus_num < m->bus_isa; bus_num++) {
 		smp_write_bus(mc, bus_num, "PCI   ");
 		printk(BIOS_DEBUG, "writing bus %d as PCI...\n",bus_num);
 	}
-	*/
+#endif
 	smp_write_bus(mc, 0, "PCI   ");
 	smp_write_bus(mc, 1, "PCI   ");
 	smp_write_bus(mc, 7, "PCI   ");

Modified: trunk/src/mainboard/kontron/kt690/mainboard.c
==============================================================================
--- trunk/src/mainboard/kontron/kt690/mainboard.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/kontron/kt690/mainboard.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -57,7 +57,7 @@
 * RRG4.2.3.1 GPM pins as Input
 * RRG4.2.3.2 GPM pins as Output
 ********************************************************/
-static void enable_onboard_nic()
+static void enable_onboard_nic(void)
 {
 	u8 byte;
 
@@ -94,7 +94,7 @@
 * IDE_DMA66 is routed to GPIO 9. So we read Gpio 9 to
 * get the cable type, 40 pin or 80 pin?
 ********************************************************/
-static void get_ide_dma66()
+static void get_ide_dma66(void)
 {
 	u8 byte;
 	struct device *sm_dev;
@@ -120,7 +120,7 @@
 /*
  * set thermal config
  */
-static void set_thermal_config()
+static void set_thermal_config(void)
 {
 	u8 byte;
 	u16 word;

Modified: trunk/src/mainboard/pcengines/alix1c/romstage.c
==============================================================================
--- trunk/src/mainboard/pcengines/alix1c/romstage.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/pcengines/alix1c/romstage.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -145,8 +145,6 @@
 		{.channel0 = {0x50}},
 	};
 
-	extern void RestartCAR();
-
 	post_code(0x01);
 
 	SystemPreInit();

Modified: trunk/src/mainboard/technexion/tim8690/mainboard.c
==============================================================================
--- trunk/src/mainboard/technexion/tim8690/mainboard.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/mainboard/technexion/tim8690/mainboard.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -54,7 +54,7 @@
 * Both of their pin PERSTn pins are connected to GPIO 5 of the
 * SB600 southbridge.
 ****************************************************/
-static void enable_onboard_nic()
+static void enable_onboard_nic(void)
 {
 
 	u8 byte;
@@ -80,7 +80,7 @@
 
 /* set thermal config
  */
-static void set_thermal_config()
+static void set_thermal_config(void)
 {
 	u8 byte;
 	u16 word;

Modified: trunk/src/northbridge/amd/amdht/h3finit.c
==============================================================================
--- trunk/src/northbridge/amd/amdht/h3finit.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/amd/amdht/h3finit.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -1692,7 +1692,7 @@
  *	@param[out] result BOOL  = true if check is ok, false if it failed
  * ---------------------------------------------------------------------------------------
  */
-BOOL isSanityCheckOk()
+BOOL isSanityCheckOk(void)
 {
 	uint64 qValue;
 

Modified: trunk/src/northbridge/amd/gx2/northbridge.c
==============================================================================
--- trunk/src/northbridge/amd/gx2/northbridge.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/amd/gx2/northbridge.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -123,9 +123,9 @@
 };
 
 /* note that dev is NOT used -- yet */
-static void irq_init_steering(struct device *dev, uint16_t irq_map) {
+static void irq_init_steering(struct device *dev, u16 irq_map) {
 	/* Set up IRQ steering */
-	uint32_t pciAddr = 0x80000000 | (CHIPSET_DEV_NUM << 11) | 0x5C;
+	u32 pciAddr = 0x80000000 | (CHIPSET_DEV_NUM << 11) | 0x5C;
 
 	printk(BIOS_DEBUG, "%s(%p [%08X], %04X)\n", __func__, dev, pciAddr, irq_map);
 
@@ -298,17 +298,17 @@
 /* this is a test -- we are not sure it will work -- but it ought to */
 static void set_resources(struct device *dev)
 {
+#if 0
         struct resource *resource, *last;
-        unsigned link;
-        uint8_t line;
 
-#if 0
         last = &dev->resource[dev->resources];
 
         for(resource = &dev->resource[0]; resource < last; resource++) {
                 pci_set_resource(dev, resource);
         }
 #endif
+        unsigned link;
+
         for(link = 0; link < dev->links; link++) {
                 struct bus *bus;
                 bus = &dev->link[link];
@@ -327,7 +327,7 @@
         }
 
         /* zero the irq settings */
-        line = pci_read_config8(dev, PCI_INTERRUPT_PIN);
+        u8 line = pci_read_config8(dev, PCI_INTERRUPT_PIN);
         if (line) {
                 pci_write_config8(dev, PCI_INTERRUPT_LINE, 0);
         }
@@ -383,10 +383,10 @@
 }
 
 #if 0
-static uint32_t find_pci_tolm(struct bus *bus)
+static u32 find_pci_tolm(struct bus *bus)
 {
 	struct resource *min;
-	uint32_t tolm;
+	u32 tolm;
 	min = 0;
 	search_bus_resources(bus, IORESOURCE_MEM, IORESOURCE_MEM, tolm_test, &min);
 	tolm = 0xffffffffUL;
@@ -402,7 +402,7 @@
 {
 #if 0
 	device_t mc_dev;
-        uint32_t pci_tolm;
+        u32 pci_tolm;
 
         pci_tolm = find_pci_tolm(&dev->link[0]);
 	mc_dev = dev->link[0].children;

Modified: trunk/src/northbridge/via/vt8623/northbridge.c
==============================================================================
--- trunk/src/northbridge/via/vt8623/northbridge.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vt8623/northbridge.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -60,7 +60,10 @@
 	}
 }
 
-static void nullfunc(){}
+static void nullfunc(void)
+{
+	/* Nothing to do */
+}
 
 static struct device_operations northbridge_operations = {
 	.read_resources   = nullfunc,
@@ -104,7 +107,7 @@
 
 static void vga_init(device_t dev)
 {
-//	unsigned long fb;
+	//unsigned long fb;
 	//msr_t clocks1,clocks2,instructions,setup;
 
 	printk(BIOS_DEBUG, "VGA random fixup ...\n");

Modified: trunk/src/northbridge/via/vx800/dev_init.c
==============================================================================
--- trunk/src/northbridge/via/vx800/dev_init.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/dev_init.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -26,7 +26,7 @@
 void InitDDR2CHB(DRAM_SYS_ATTR *DramAttr);
 void InitDDR2CHC(DRAM_SYS_ATTR *DramAttr);
 
-CB_STATUS VerifyChc();
+CB_STATUS VerifyChc(void);
 
 /*===================================================================
 Function   : DRAMRegInitValue()

Modified: trunk/src/northbridge/via/vx800/dram_init.c
==============================================================================
--- trunk/src/northbridge/via/vx800/dram_init.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/dram_init.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -17,12 +17,10 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-CB_STATUS DDR2_DRAM_INIT()
+CB_STATUS DDR2_DRAM_INIT(void)
 {
-	CB_STATUS Status;
 	u8 i;
 	u32 RamSize;
-	BOOLEAN bTest;
 	DRAM_SYS_ATTR DramAttr;
 
 	PRINT_DEBUG_MEM("DRAM_INIT \r");
@@ -76,7 +74,7 @@
 	PRINT_DEBUG_MEM_HEX32(RamSize);
 	PRINT_DEBUG_MEM("\r");
 	DumpRegisters(0, 3);
-	//bTest = DramBaseTest( M1, RamSize - M1 * 2,SPARE, FALSE);
+	//BOOLEAN bTest = DramBaseTest( M1, RamSize - M1 * 2,SPARE, FALSE);
 	/* the memory can not correct work, this is because the user set the incorrect memory
 	   parameter from setup interface.so we must set the boot mode to recovery mode, let
 	   the system to reset and use the spd value to initialize the memory */

Modified: trunk/src/northbridge/via/vx800/dram_init.h
==============================================================================
--- trunk/src/northbridge/via/vx800/dram_init.h	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/dram_init.h	Wed Apr 14 12:12:23 2010	(r5425)
@@ -253,9 +253,9 @@
 void DRAMRegFinalValue(DRAM_SYS_ATTR * DramAttr);
 
 /*set UMA*/
-void SetUMARam();
+void SetUMARam(void);
 
 CB_STATUS InstallMemory(DRAM_SYS_ATTR * DramAttr, u32 RamSize);
-CB_STATUS DDR2_DRAM_INIT();
+CB_STATUS DDR2_DRAM_INIT(void);
 
 #endif

Modified: trunk/src/northbridge/via/vx800/drdy_bl.c
==============================================================================
--- trunk/src/northbridge/via/vx800/drdy_bl.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/drdy_bl.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -407,9 +407,6 @@
 	u8 Data, CL, RDRPH;
 	u8 CpuFreq, DramFreq;
 	u8 ProgData[PT894_RDRDY_TBL_Width];
-	u8 DelayMode;
-	u8 DrdyMode;
-	u8 Index;
 
 	/*
 	   this function has 3 switchs, correspond to 3 level of Drdy setting.
@@ -483,16 +480,19 @@
 	Data = pci_read_config8(MEMCTRL, 0x90);
 	DramFreq = Data & 0x07;
 
+	u8 DelayMode;
 	DelayMode = CL + RDRPH;	// RDELAYMD = bit0 of (CAS Latency + RDRPH)
 	DelayMode &= 0x01;
 
 	//In 364, there is no 128 bit
 	if (DelayMode == 1) {	// DelayMode 1
+		u8 Index;
 		for (Index = 0; Index < PT894_RDRDY_TBL_Width; Index++)
 			ProgData[Index] =
 			    PT894_64bit_DELAYMD1_RCONV0[CpuFreq][DramFreq]
 			    [Index];
 	} else {		// DelayMode 0
+		u8 Index;
 		for (Index = 0; Index < PT894_RDRDY_TBL_Width; Index++)
 			ProgData[Index] =
 			    PT894_64bit_DELAYMD0_RCONV0[CpuFreq][DramFreq]

Modified: trunk/src/northbridge/via/vx800/freq_setting.c
==============================================================================
--- trunk/src/northbridge/via/vx800/freq_setting.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/freq_setting.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -120,7 +120,7 @@
 void CalcCLAndFreq(DRAM_SYS_ATTR * DramAttr)
 {
 	u8 AllDimmSupportedCL, Tmp;
-	u8 CLMask, tmpMask, IndexDelta;
+	u8 CLMask, tmpMask;
 	u8 SckId, BitId, TmpId;
 	u16 CycTime, TmpCycTime;
 

Modified: trunk/src/northbridge/via/vx800/raminit.c
==============================================================================
--- trunk/src/northbridge/via/vx800/raminit.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/raminit.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -55,9 +55,8 @@
  * Support one dimm with up to 2 ranks
  */
 
-static void ddr2_ram_setup()
+static void ddr2_ram_setup(void)
 {
-	u8 Data;
 	CB_STATUS Status;
 	PRINT_DEBUG_MEM("In ddr2_ram_setup\r");
 

Modified: trunk/src/northbridge/via/vx800/rank_map.c
==============================================================================
--- trunk/src/northbridge/via/vx800/rank_map.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/rank_map.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -138,7 +138,6 @@
 	u32 Size;
 	BOOLEAN HasThreeBitBA;
 	u8 Data;
-	u32 Address;
 
 	HasThreeBitBA = FALSE;
 	for (Slot = 0; Slot < 2; Slot++) {

Modified: trunk/src/northbridge/via/vx800/uma_ram_setting.c
==============================================================================
--- trunk/src/northbridge/via/vx800/uma_ram_setting.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/uma_ram_setting.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -333,6 +333,7 @@
 	ByteVal = (ByteVal & 0xE5) | 0x1A;
 	outb(ByteVal, 0x03d5);
 
+#if 0
 	u8 table3c43c5[0x70] = {
 		0x03, 0x01, 0x0F, 0x00, 0x06, 0x00, 0x00, 0x00,
 		0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
@@ -395,9 +396,9 @@
 		0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
 		0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF,
 	};
-#if 0
-//for(i=0;i<0xc0;i++)
-	for (i = 0; i < 0x40; i++)	//
+
+	//for(i=0;i<0xc0;i++)
+	for (i = 0; i < 0x40; i++)
 	{
 		outb(table3c0space[i], 0x03c0 + i);
 	}
@@ -410,6 +411,7 @@
 		outb(i, 0x03d4);
 		outb(table3d43d5[i], 0x03d5);
 	}
+
 	outb(0x92, 0x03d4);
 	outb(0x80, 0x03d5);
 
@@ -419,12 +421,12 @@
 	outb(0xe8, 0x03d4);
 	outb(0x40, 0x03d5);
 #endif
-//3d4 3d freq
-//IO Port / Index: 3X5.3D
-//Scratch Pad Register 4
 
-//    outb(0x39,0x03c4);//
-	//outb(1 << SLD0F3Val ,0x03c5);
+// 3d4 3d freq
+// IO Port / Index: 3X5.3D
+// Scratch Pad Register 4
+//	outb(0x39,0x03c4);
+//	outb(1 << SLD0F3Val ,0x03c5);
 //
 #endif
 

Modified: trunk/src/northbridge/via/vx800/vgabios.c
==============================================================================
--- trunk/src/northbridge/via/vx800/vgabios.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/northbridge/via/vx800/vgabios.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -299,8 +299,6 @@
 	unsigned char *buf;
 	unsigned int size = 64 * 1024;
 	int i;
-	u16 tmp;
-	u8 tmp8;
 
 	printk(BIOS_EMERG, "file '%s', line %d\n\n", __FILE__, __LINE__);
 
@@ -646,15 +644,7 @@
 	unsigned long *pesp, unsigned long *pebx, unsigned long *pedx,
 	unsigned long *pecx, unsigned long *peax, unsigned long *pflags)
 {
-	unsigned long edi = *pedi;
-	unsigned long esi = *pesi;
-	unsigned long ebp = *pebp;
-	unsigned long esp = *pesp;
-	unsigned long ebx = *pebx;
-	unsigned long edx = *pedx;
-	unsigned long ecx = *pecx;
 	unsigned long eax = *peax;
-	unsigned long flags = *pflags;
 	unsigned short func = (unsigned short)eax;
 	int retval = 0;
 	unsigned short devid, vendorid, devfn;

Modified: trunk/src/southbridge/amd/cs5535/cs5535_early_setup.c
==============================================================================
--- trunk/src/southbridge/amd/cs5535/cs5535_early_setup.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/amd/cs5535/cs5535_early_setup.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -23,11 +23,11 @@
 
 	/* forward MSR access to CS5535_GLINK_PORT_NUM to CS5535_DEV_NUM */
 	msr.hi = msr.lo = 0x00000000;
-	if (CS5535_GLINK_PORT_NUM <= 4) {
-		msr.lo = CS5535_DEV_NUM << ((CS5535_GLINK_PORT_NUM - 1) * 8);
-	} else {
-		msr.hi = CS5535_DEV_NUM << ((CS5535_GLINK_PORT_NUM - 5) * 8);
-	}
+#if CS5535_GLINK_PORT_NUM <= 4
+	msr.lo = CS5535_DEV_NUM << ((CS5535_GLINK_PORT_NUM - 1) * 8);
+#else
+	msr.hi = CS5535_DEV_NUM << ((CS5535_GLINK_PORT_NUM - 5) * 8);
+#endif
 	wrmsr(0x5000201e, msr);
 }
 

Modified: trunk/src/southbridge/amd/cs5536/cs5536_smbus2.h
==============================================================================
--- trunk/src/southbridge/amd/cs5536/cs5536_smbus2.h	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/amd/cs5536/cs5536_smbus2.h	Wed Apr 14 12:12:23 2010	(r5425)
@@ -239,9 +239,9 @@
 		*data++ = val;
 
 		if (count > 1) {
-			int ret = smbus_wait(smbus_io_base);
+			ret = smbus_wait(smbus_io_base);
 			if (ret)
-				return ret;
+				return;
 		}
 
 		count--;

Modified: trunk/src/southbridge/intel/i82801ex/i82801ex_early_smbus.c
==============================================================================
--- trunk/src/southbridge/intel/i82801ex/i82801ex_early_smbus.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/intel/i82801ex/i82801ex_early_smbus.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -66,8 +66,6 @@
 static int smbus_write_block(unsigned device, unsigned length, unsigned cmd, 
 		 unsigned data1, unsigned data2)
 {
-	unsigned char global_control_register;
-	unsigned char global_status_register;
 	unsigned char byte;
 	unsigned char stat;
 	int i;

Modified: trunk/src/southbridge/nvidia/mcp55/mcp55_early_setup_car.c
==============================================================================
--- trunk/src/southbridge/nvidia/mcp55/mcp55_early_setup_car.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/nvidia/mcp55/mcp55_early_setup_car.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -388,7 +388,7 @@
 	int mcp55_num = 0;
 	unsigned busnx;
 	unsigned devnx;
-	int ht_c_index,j;
+	int ht_c_index;
 
 	/* FIXME: multi pci segment handling */
 

Modified: trunk/src/southbridge/nvidia/mcp55/mcp55_fadt.c
==============================================================================
--- trunk/src/southbridge/nvidia/mcp55/mcp55_fadt.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/nvidia/mcp55/mcp55_fadt.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -51,8 +51,8 @@
 
 	printk(BIOS_INFO, "ACPI: pm_base: %u...\n", pm_base);
 
-	fadt->firmware_ctrl = facs;
-	fadt->dsdt = dsdt;
+	fadt->firmware_ctrl = (u32)facs;
+	fadt->dsdt = (u32)dsdt;
 	fadt->preferred_pm_profile = 1; //check
 	fadt->sci_int = 9;
 	/* disable system management mode by setting to 0 */
@@ -108,9 +108,9 @@
 	fadt->reset_reg.addrh = 0x0;
 
 	fadt->reset_value = 0;
-	fadt->x_firmware_ctl_l = facs;
+	fadt->x_firmware_ctl_l = (u32)facs;
 	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = dsdt;
+	fadt->x_dsdt_l = (u32)dsdt;
 	fadt->x_dsdt_h = 0;
 
 	fadt->x_pm1a_evt_blk.space_id = 1;

Modified: trunk/src/southbridge/via/vt8235/vt8235.c
==============================================================================
--- trunk/src/southbridge/via/vt8235/vt8235.c	Wed Apr 14 11:04:31 2010	(r5424)
+++ trunk/src/southbridge/via/vt8235/vt8235.c	Wed Apr 14 12:12:23 2010	(r5425)
@@ -41,7 +41,7 @@
 	}
 }
 
-void set_led()
+void set_led(void)
 {
 	// set power led to steady now that lxbios has virtually done its job
 	device_t dev;




More information about the coreboot mailing list