[coreboot] [PATCH] Get rid of unaligned 32-bit config space read in mcd_d.c

Arne Georg Gleditsch arne.gleditsch at numascale.com
Tue Apr 13 09:40:09 CEST 2010

Marc Jones <marcj303 at gmail.com> writes:
> That code is doing something a little ugly to make the two cs
> registers use the one mask register. It was ported from a routine that
> assumed that GET_NB32() fixed the alignment. Maybe add a comment about
> why that is happening.

I assumed as much.  I'll see if I can't put a comment in.

> Acked-by: Marc Jones <marcj303 at gmail.com>
> I would also ack a change to:
> u32 Get_NB32(u32 dev, u32 reg)
> u32 Get_NB32(u32 dev, u32 reg)
> or to the  pci_mmio_*_config* to do it since the pci_io* versions do.

Thanks, I'll include this as well.  The current situation with different
semantics on unaligned accesses isn't really helping anyone, as far as I
can see.


More information about the coreboot mailing list