[coreboot] more Kconfig fixes

Patrick Georgi patrick at georgi-clan.de
Tue Sep 29 16:39:50 CEST 2009


Am Dienstag, den 29.09.2009, 08:21 -0600 schrieb Myles Watson:
> Index: src/mainboard/intel/xe7501devkit/Makefile.inc
> ===================================================================
> --- src/mainboard/intel/xe7501devkit/Makefile.inc	(Revision 4683)
> +++ src/mainboard/intel/xe7501devkit/Makefile.inc	(Arbeitskopie)
> @@ -1,7 +1,7 @@
>  ROMCCFLAGS := -mcpu=p4
>  obj-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.o
>  ifeq ($(CONFIG_PCI_ROM_RUN),y)
> -	ifeq ($(CONFIG_PCI_ROM_RUN),y)
> +	ifeq ($(CONFIG_CONSOLE_VGA),y)
> I think this should be CONFIG_VGA_ROM_RUN.  CONFIG_CONSOLE_VGA is for the
> Coreboot console messages.
It's the same thing Config.lb is doing. If this is broken, Config.lb
should be fixed, too.

> This whole part can be removed since it includes the binary vga.rom which
> isn't in the tree.  CBFS can help us remove no_vgarom.S, vgarom.S, and the
> reference to _vgarom_start in the device tree.
Yes, the vgarom.S hack is really horrible, but it's a bit of work to get
rid of it - in both Config.lb and this one.


> > Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
> Acked-by: Myles Watson <mylesgw at gmail.com>
Thanks,  r4685





More information about the coreboot mailing list