[coreboot] more Kconfig fixes

Myles Watson mylesgw at gmail.com
Tue Sep 29 16:21:00 CEST 2009

Index: src/mainboard/intel/xe7501devkit/Makefile.inc
--- src/mainboard/intel/xe7501devkit/Makefile.inc	(Revision 4683)
+++ src/mainboard/intel/xe7501devkit/Makefile.inc	(Arbeitskopie)
@@ -1,7 +1,7 @@
 ROMCCFLAGS := -mcpu=p4
 obj-$(CONFIG_HAVE_ACPI_TABLES) += acpi_tables.o
 ifeq ($(CONFIG_PCI_ROM_RUN),y)
-	ifeq ($(CONFIG_PCI_ROM_RUN),y)
+	ifeq ($(CONFIG_CONSOLE_VGA),y)
I think this should be CONFIG_VGA_ROM_RUN.  CONFIG_CONSOLE_VGA is for the
Coreboot console messages.

This whole part can be removed since it includes the binary vga.rom which
isn't in the tree.  CBFS can help us remove no_vgarom.S, vgarom.S, and the
reference to _vgarom_start in the device tree.

> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
Acked-by: Myles Watson <mylesgw at gmail.com>


More information about the coreboot mailing list