[coreboot] [PATCH] Re-enable option table for the ASUS MEW-VM and fix build
uwe at hermann-uwe.de
Thu Sep 24 16:08:42 CEST 2009
On Thu, Sep 24, 2009 at 03:04:10PM +0200, Patrick Georgi wrote:
> Am Donnerstag, den 24.09.2009, 14:52 +0200 schrieb Uwe Hermann:
> > Most of the patch looks good, but disabling HAVE_OPTION_TABLE is
> > incorrect I think, as the board _does_ have a cmos.layout file.
> I simply made it correspond to the newconfig configuration:
> Options.lb:default CONFIG_HAVE_OPTION_TABLE = 0
Hm, probably yet another copy-paste occurance in our tree, the
cmos.layout got copied and never enabled or so. Anyway, we should
fix this in another patch by (IMHO) making one or two "generic"
cmos.layout files which boards without special needs can use.
I estimate that 80% or so of all those files are identical and/or
blindly copy-pasted. Those boards that _do_ need a differing cmos.layout
should have their own custom file, but the "don't care" rest of the
boards can then use a global/common one.
> > The bug which prevented a successful build was a typo in the
> > Makefile. Attached patch should fix it.
> I don't care about any improvements over that at this time, but the
> change in Makefile.romccboard.inc looks fine.
> In case this is build tested by you (esp. that asus/mew-vm really
> builds), this is
> Acked-by: Patrick Georgi <patrick.georgi at coresystems.de>
Thanks, r4669. I manually tested the board via menuconfig.
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot