[coreboot] [PATCH] Re-enable option table for the ASUS MEW-VM and fix build

Uwe Hermann uwe at hermann-uwe.de
Thu Sep 24 14:52:41 CEST 2009


On Thu, Sep 24, 2009 at 10:39:55AM +0200, Patrick Georgi wrote:
> Hi,
> 
> with this patch (and my previous one), all kconfig enabled boards build
> for me.
> 
> Changes this time:
> - Fix for superio/smsc/lpc47b272
> - disable option table for asus/mew-vm
> - change superio to use for compaq/deskpro_en_sff_p600 to be in line
>   with what newconfig/buildtarget does
> 
> 
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>

This was r4666.

Most of the patch looks good, but disabling HAVE_OPTION_TABLE is
incorrect I think, as the board _does_ have a cmos.layout file.

The bug which prevented a successful build was a typo in the
Makefile. Attached patch should fix it.


> Index: src/mainboard/compaq/deskpro_en_sff_p600/Kconfig
> ===================================================================
> --- src/mainboard/compaq/deskpro_en_sff_p600/Kconfig	(Revision 4665)
> +++ src/mainboard/compaq/deskpro_en_sff_p600/Kconfig	(Arbeitskopie)
> @@ -24,7 +24,8 @@
>  	select CPU_INTEL_SLOT_2
>  	select NORTHBRIDGE_INTEL_I440BX
>  	select SOUTHBRIDGE_INTEL_I82371EB
> -	select SUPERIO_NSC_PC97307
> +	# should be SUPERIO_NSC_PC97307!
> +	select SUPERIO_NSC_PC97317
>  	select HAVE_PIRQ_TABLE
>  	select UDELAY_IO
>  	select PCI_ROM_RUN

Yep, the PC97307 doesn't properly build right now (if it ever did), will
look into it.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2_kconfig_option_table_fix.patch
Type: text/x-diff
Size: 1238 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090924/1ba1a70a/attachment.bin>


More information about the coreboot mailing list