[coreboot] build service results for r4654

coreboot information info at coresystems.de
Tue Sep 22 19:53:14 CEST 2009

Dear coreboot readers!

This is the automatic build system of coreboot.

The developer "stepan" checked in revision 4654 to
the coreboot repository. This caused the following 

Change Log:
This separates the code for each command in cbfstool. For the good and for the
bad: It brings a certain amount of code duplication (some of which can be
cleaned up again, or get rid of by proper refactoring).
On the other hand now there's a very simple code flow for each command, rather
than for each operation. ie.

adding a file to a cbfs means:
 - open the cbfs
 - add the file
 - close the cbfs

rather than

open the cbfs:
 - do this for add, remove, but not for create

create a new lar
 - if we don't have an open one yet

add a file:
 - if we didn't bail out before

close the file:
 - if we didn't bail out before

The short term benefit is that this fixes a problem where cbfstool was trying
to add a file if you gave a non-existing command because it bailed out on
known, not on unknown commands.

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Peter Stuge <peter at stuge.se>

Build Log:
Compilation of embeddedplanet:ep405pc is still broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4654&device=ep405pc&vendor=embeddedplanet&num=2
Compilation of motorola:sandpointx3_altimus_mpc7410 is still broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4654&device=sandpointx3_altimus_mpc7410&vendor=motorola&num=2
Compilation of totalimpact:briq is still broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4654&device=briq&vendor=totalimpact&num=2

If something broke during this checkin please be a pain 
in stepan's neck until the issue is fixed.

If this issue is not fixed within 24h the revision should 
be backed out.

   Best regards,
     coreboot automatic build system

More information about the coreboot mailing list