[coreboot] build service results for r4646

coreboot information info at coresystems.de
Tue Sep 22 02:32:40 CEST 2009

Dear coreboot readers!

This is the automatic build system of coreboot.

The developer "hailfinger" checked in revision 4646 to
the coreboot repository. This caused the following 

Change Log:
If no pci access method has been set for the device tree so far (e.g.
during early coreboot_ram), pci_{read,write}_config{8,16,32} will die().
This patch changes pci_{read,write}_config{8,16,32} to use the existing
PCI access method autodetection infrastructure instead of die()ing.

Until r4340, any usage of pci_{read,write}_config{8,16,32} in
coreboot_ram before the device tree was set up resulted in either a
silent hang or a NULL pointer dereference. I changed the code in r4340
to die() properly with a loud error message. That still was not perfect,
but at least it allowed people to see why their new ports died.
Still, die() is not something developers like to see, and thus a patch
to automatically pick a sensible default instead of dying was created.
Of course, handling PCI access method selection automatically for
fallback purposes has certain limitations before the device tree is set
up. We only check if conf1 works and use conf2 as fallback. No further
tests are done.

This patch enables cleanups and readability improvements in early
coreboot_ram code:
Without this patch:
dword = pci_cf8_conf1.read32(&pbus, sm_dev->bus->secondary,
        sm_dev->path.pci.devfn, 0x64);
With this patch:
dword = pci_read_config32(sm_dev, 0x64);

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Acked-by: Peter Stuge <peter at stuge.se>

Build Log:
Compilation of embeddedplanet:ep405pc has been broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4646&device=ep405pc&vendor=embeddedplanet&num=2
Compilation of motorola:sandpointx3_altimus_mpc7410 has been broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4646&device=sandpointx3_altimus_mpc7410&vendor=motorola&num=2
Compilation of totalimpact:briq has been broken
See the error log at http://qa.coreboot.org/log_buildbrd.php?revision=4646&device=briq&vendor=totalimpact&num=2

If something broke during this checkin please be a pain 
in hailfinger's neck until the issue is fixed.

If this issue is not fixed within 24h the revision should 
be backed out.

   Best regards,
     coreboot automatic build system

More information about the coreboot mailing list