[coreboot] Geode LX VGA BIOS Patch
kevin at koconnor.net
Wed Sep 16 04:11:14 CEST 2009
On Sun, Sep 13, 2009 at 03:48:58PM -0400, Chris Kindt wrote:
> Kevin O'Connor wrote:
>> As before, the main seabios patch looks good to me. The "modehack"
>> patch, of course, needs to be cleaned up before committing. Are you
>> still working on this?
> Yes, it is on my todo list. I was thinking about using a device
> operations structure or macros to replace the "if(hw_type)"
> statements. This might be overkill at the moment, however it would
> be helpful for any future hardware specific expansion. I am lacking
> insight on what such a struct should be. The following example is
> crafted mostly to fix the current problems I am having.
Is the intent to support multiple hardware backends with the same
option rom binary?
The "if(hw_type)" scheme has the benefit that gcc can remove the
unused code from the resulting binary. I think that will be harder
for gcc if function pointers are used.
More information about the coreboot