[coreboot] [PATCH] Start unifying ram_check() usage in coreboot

Peter Stuge peter at stuge.se
Sat Oct 31 23:55:46 CET 2009

Stefan Reinauer wrote:

NAK +1.

> I don't think this should be user visible. In fact I think it
> should be dropped from all boards once they are working.

I agree with this.

> The test is bogus and only capable of finding crude coding errors.
> So either you're a developer and know how to put the code there, or
> you shouldn't know about it.

It's also not very nice to have a library function be conditionally
empty depending on configuration. I think it would be better to move
towards fewer lines of code in cache_as_ram_auto.c, not more.


More information about the coreboot mailing list