[coreboot] [PATCH] Remove warnings

Peter Stuge peter at stuge.se
Fri Oct 30 02:35:10 CET 2009

Myles Watson wrote:
> These three patches get rid of a few more warnings for me.
> abuild tested.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Acked-by: Peter Stuge <peter at stuge.se>

> PS.  It looks like part of the reason we have so many warnings is
> the misuse of #define __ROMCC__ to mean "early code before the
> device tree is available"  __ROMCC__ is also used to get rid of
> prototypes because romcc doesn't support them.  What's the right
> thing to do here?  Maybe we should split the meanings so that we
> test for __GNUC__ when we mean "not romcc", and we test for
> __ROMCC__ (renamed, of course, later) when we mean early init?

I'd like __ROMCC__ to stay, but I agree very much with a new #define


More information about the coreboot mailing list