[coreboot] [PATCH] resource allocator hole handling (simple and old)

Myles Watson mylesgw at gmail.com
Wed Oct 28 15:51:46 CET 2009


> I checked the code and size 0 resources are skipped already..
Yes, I should have remembered that.

> so generally that check for res->size could be dropped completely in
> above construct, making it
> 
>          /* Is it already outside the limits? */
> -        if (res->size && (((res->base + res->size -1) < lim->base) ||
> -                  (res->base > lim->limit)))
> +        if (((res->base + res->size -1) < lim->base) || (res->base >
> lim->limit))
>              continue;
That could be done.  There's no functional difference as long as the check
for size 0 resources stays.

Thanks,
Myles






More information about the coreboot mailing list