[coreboot] [PATCH] Add kconfig menus for most chipset VIDEO_MB values
joe at settoplinux.org
Tue Oct 27 04:03:48 CET 2009
Sweet! Great work Uwe, I really like this. Even though it is too late:
Acked-by: Joseph Smith <joe at settoplinux.org>
>> I think it's pretty ugly to have 512 be the value for CONFIG_VIDEO_MB that
>> means 512K. I know you didn't do that, but... Maybe we could just say the
>> 512K of RAM doesn't make that much difference and make the minimum 1MB?
> Yeah, the 512KB thing is not really nice, but there's not much we can do
> about it. We could turn VIDEO_MB into VIDEO_KB instead to have the same
> unit everywhere, not sure if that's nicer or uglier.
> I don't want to leave out valid options supported by the hardware
> though, so the 512KB setting should stay. I think it's not _that_ big
> of a problem as the uglyness is only visible to the developers of
> two chipsets I think (i810 and i830), but not to the other developers
> and especially not to the user (who sees nice menuconfig entries).
> We can leave it as is IMHO.
Yes it is ugly but decimals would be uglier (0.5MB) especially in
calculations. Anyways if it is supported by the chip it should be there.
More information about the coreboot