[coreboot] SMM included twice

Myles Watson mylesgw at gmail.com
Mon Oct 26 17:14:39 CET 2009


src/cpu/x86/smm/Makefile.inc:33: warning: overriding commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o'
src/cpu/x86/smm/Makefile.inc:33: warning: ignoring old commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o'
src/cpu/x86/smm/Makefile.inc:36: warning: overriding commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm'
src/cpu/x86/smm/Makefile.inc:36: warning: ignoring old commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm'
src/cpu/x86/smm/Makefile.inc:41: warning: overriding commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c'
src/cpu/x86/smm/Makefile.inc:41: warning: ignoring old commands for target
`/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c'

myles at orangutan:svn$ grep -Ir subdirs.*smm src/ | grep -v svn
src/cpu/x86/Makefile.inc:subdirs-y += smm
src/cpu/via/model_c7/Makefile.inc:subdirs-y += ../../x86/smm
src/cpu/via/model_c3/Makefile.inc:subdirs-y += ../../x86/smm
src/cpu/intel/ep80579/Makefile.inc:subdirs-y += ../../x86/smm

First it gets included with src/cpu/x86, then with every cpu model.  Can we
just remove those?

subdirs-y += amd
subdirs-y += intel
subdirs-y += via
subdirs-y += emulation
subdirs-y += x86

This is a little strange, though.  All the rest are brands.

To be consistent, I think we should remove subdirs-y += x86 from
src/cpu/Makefile.inc, and let every CPU include it.  Patch attached.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

I'd be equally happy with every CPU (since we only have x86), just doing
subdir-y += ../../x86 so they didn't have to be repeated.

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091026/4de42c16/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smm_warnings.diff
Type: text/x-patch
Size: 464 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091026/4de42c16/attachment.diff>


More information about the coreboot mailing list