[coreboot] [PATCH] More Kconfig changes

Uwe Hermann uwe at hermann-uwe.de
Sun Oct 25 01:11:49 CEST 2009

On Fri, Oct 23, 2009 at 05:06:35PM -0600, Myles Watson wrote:
> On Fri, Oct 23, 2009 at 4:56 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> > On Fri, Oct 23, 2009 at 02:43:27PM -0600, Myles Watson wrote:
> > > Ping.  I think I've addressed all of Peter and Uwe's concerns.
> >
> > I Think so, but please repost the updated patch so we can have a look
> > at the final version.
> >
> I don't think the first patches have changed much, but there are two new
> ones that apply on top: peter.diff and uwe.diff.
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

> +	bool
> +	default y
> +	help
> +	  This Option is unused in the code.  Since two boards try to set it to
> +	  'n', they may be broken.  We either need to make the option useful or
> +	  get rid of it.  The broken boards are:
> +	  asus/m2v-mx_se
> +	  supermicro/h8dme

Please add a "# TODO" comment on top of that for easy grepping.

> +config MEM_TRAIN_SEQ
> +	int
> +	default 2

We should add a MEM_TRAIN_SEQ comment or help text, it's unclear to me what it is
supposed to do. Is it a per-chipset, per-cpu, or per-board option? What
do the values of the variable mean?

Regardless of that, it seems like it should be a user-visible option in
menuconfig with useful option names for the values of 0, 1, and 2 (which
seem to be the only valid ones).

That's for another patch though.

http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list