[coreboot] [PATCH] refactor SMI handler
Stefan Reinauer
stepan at coresystems.de
Sat Oct 24 20:02:49 CEST 2009
Myles Watson wrote:
>
>
> 2009/10/23 Stefan Reinauer <stepan at coresystems.de
> <mailto:stepan at coresystems.de>>
>
> See patch
>
> --
> coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
> Tel.: +49 761 7668825 • Fax: +49 761 7664613
> Email: info at coresystems.de <mailto:info at coresystems.de> •
> http://www.coresystems.de/
> Registergericht: Amtsgericht Freiburg • HRB 7656
> Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
>
>
> * refactor x86 smi handler (put all debug stuff in an extra file
> smiutil.c)
> * lock other CPUs in SMI handler while one CPU is handling an SMI.
> Without this
> various racing scenarios could happen.
>
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de
> <mailto:stepan at coresystems.de>>
>
> Acked-by: Myles Watson <mylesgw at gmail.com <mailto:mylesgw at gmail.com>>
Thanks, r4840.
> Is there some header file that could be included for these defines?
> Maybe even config.h?
>
>
> +#ifndef CONFIG_TTYS0_BASE
> +#define CONFIG_TTYS0_BASE 0x3f8
> +#endif
>
>
No, but it would make sense... What's the right place for this?
include/uart8250.h ?
Right now they are defined in
./src/arch/i386/init/crt0.S.lb
./src/console/uart8250_console.c
./src/cpu/amd/model_lx/cache_as_ram.inc
./src/cpu/x86/smm/smiutil.c
./src/pc80/serial.c
More information about the coreboot
mailing list