[coreboot] [v2] r4836 - trunk/coreboot-v2/src/lib

[svn at coreboot.org]

Author: stepan
Date: 2009-10-24 15:02:14 +0200 (Sat, 24 Oct 2009)
New Revision: 4836

Modified:
   trunk/coreboot-v2/src/lib/usbdebug_direct.c
Log:
Fix USB Debug Device for Intel ICH chipsets

The USB EHCI controller reset is not really needed on ICH, and in fact 
the code bailed out there which is the most stupid thing to do. So just
keep trying.

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>



Modified: trunk/coreboot-v2/src/lib/usbdebug_direct.c
===================================================================
--- trunk/coreboot-v2/src/lib/usbdebug_direct.c	2009-10-24 12:40:52 UTC (rev 4835)
+++ trunk/coreboot-v2/src/lib/usbdebug_direct.c	2009-10-24 13:02:14 UTC (rev 4836)
@@ -407,11 +407,10 @@
 		cmd = readl(&ehci_regs->command);
 	} while ((cmd & CMD_RESET) && (--loop > 0));
 
-	if(!loop) {
+	if(!loop)
 		dbgp_printk("Could not reset EHCI controller.\n");
-		return;
-	}
-	dbgp_printk("EHCI controller reset successfully.\n");
+	else
+		dbgp_printk("EHCI controller reset successfully.\n");
 
 	/* Claim ownership, but do not enable yet */
 	ctrl = readl(&ehci_debug->control);