[coreboot] [PATCH] Major cleanups of hard_reset() related code/config

[Myles Watson]

On Mon, Oct 19, 2009 at 6:15 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:

> See patch.
>
> I'm happy for any comments. Also, I'm not sure how all this
> hard_reset() stuff is meant to work. Many southbridges have _two_
> implementations of hard_reset(). Why? Some only have one.
>

> Index: src/southbridge/amd/amd8111/amd8111_reset.c
> ===================================================================
> --- src/southbridge/amd/amd8111/amd8111_reset.c    (Revision 4813)
> +++ src/southbridge/amd/amd8111/amd8111_reset.c    (Arbeitskopie)
> @@ -54,6 +54,7 @@
>  #include "../../../northbridge/amd/amdk8/reset_test.c"
>
>
> +/* FIXME: There's another implementation in amd8111_early_ctrl.c. Why? */
>  void hard_reset(void)
>  {
>      device_t dev;
> Index: src/southbridge/amd/amd8111/amd8111_early_ctrl.c
> ===================================================================
> --- src/southbridge/amd/amd8111/amd8111_early_ctrl.c    (Revision 4813)
> +++ src/southbridge/amd/amd8111/amd8111_early_ctrl.c    (Arbeitskopie)
> @@ -35,6 +35,7 @@
>      enable_cf9_x(sbbusn, sbdn);
>  }
>
> +/* FIXME: There's another implementation in amd8111_reset.c. Why? */
>  static void hard_reset(void)
>  {
>          set_bios_reset();
>
CAR code has its own implementation of many functions: printk, die, HT
initialization, ...

The early files are inlcuded into the cache_as_ram_auto.c, and the other
ones are used with coreboot_ram.

>  - Drop hard_reset() dummy from asus/a8v-e_se and asus/m2v-mx_se.
>    As mentioned by ruik on IRC, the soft_reset() function already does a
>    hard reset, so this function is not needed.

I think it's a bug to have soft_reset() do a hard reset.

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091020/a6284bca/attachment.html>