[coreboot] [PATCH] Make COM port selection and BAUD rate a "choice"

Peter Stuge peter at stuge.se
Sat Oct 17 00:28:40 CEST 2009

Uwe Hermann wrote:
> Make COM port selection and BAUD rate a "choice" for better usability.

Must they be called COM ports? And how come BAUD is all caps?

> +choice
> +	prompt "COM port"

"Serial port" ?



>  config TTYS0_BASE

And here it's called TTYS0. This is a little too much variation.

> -	hex "I/O base for the serial port"
> +	hex
>  	depends on CONSOLE_SERIAL8250
> -	default 0x3f8
> +	default 0x3f8 if CONSOLE_SERIAL_COM1
> +	default 0x2f8 if CONSOLE_SERIAL_COM2
> +	default 0x3e8 if CONSOLE_SERIAL_COM3
> +	default 0x2e8 if CONSOLE_SERIAL_COM4

These I/O ports <-> serial ports aren't neccessarily true. Maybe
have the I/O visible in the options?

I like the choice for speed!


More information about the coreboot mailing list