[coreboot] [PATCH]: vga bios was added into image by cbfstool, not by "cat" any more.

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Oct 16 09:27:09 CEST 2009


On 16.10.2009 08:38, Bao, Zheng wrote:
> Add CONFIG_VGA_ROM_RUN to dbm690t and pistachio, otherwise the
> VGA ROM can not run. After make, run
>   
>> ./cbfs/cbfstool ./coreboot.rom add ../vga_bios.rom   pci1002,791f.rom
>>     
> optionrom
> to make the final image with vga bios.
>
> The macro vga_rom_address is out-of-date when CBFS starts play its role.
> it also should
> be eliminated from rs690/chip.h as below. But it will cause building
> error on other board, which I
> can not make test on.
>
> Signed-off-by: Zheng Bao <zheng.bao at amd.com>
>   

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Can you please send a fixup patch for the other boards as well?
Libra Li and Daniel Toussaint and Stefan Reinauer are reading this list,
so the patch can be tested on all other RS690 targets easily.

Regards,
Carl-Daniel

-- 
Developer quote of the week: 
"We are juggling too many chainsaws and flaming arrows and tigers."





More information about the coreboot mailing list