[coreboot] [PATCH] s289x ACPI fix

ron minnich rminnich at gmail.com
Fri Oct 16 05:21:08 CEST 2009

On Thu, Oct 15, 2009 at 5:24 PM, Peter Stuge <peter at stuge.se> wrote:
> Myles Watson wrote:

>> +             #if !CONFIG_HAVE_MP_TABLE /* Initialize interrupt mapping. */
>> +             {
>> +                     u32 dword;
>> +                     dword = 0x0120d218;
>> +                     pci_write_config32(dev, 0x7c, dword);
> I don't think this is how Ron meant he likes CONFIG_ values in code.
> More like:
> }
> Personally I favor letting the preprocessor do preprocessing, rather
> than pushing this type of code removal to the compiler.

I'm not going to worry about this type of thing, but it is interesting
that even we let cpp do it, we try to indent and make
it look like C code, eh?

But #if value is fine if that is what you want to do. It's the #ifdef
that has caused trouble in the past. And, in the end, I do like to let
the C compiler do the work, true. But I'm in good company, the guys
who invented C are the guys who convinced me :-)



More information about the coreboot mailing list