[coreboot] [v2] r4780 - trunk/coreboot-v2/src

Myles Watson mylesgw at gmail.com
Thu Oct 15 20:01:12 CEST 2009


> Modified:
>    trunk/coreboot-v2/src/Kconfig
> Log:
> Start documenting a few kconfig variables and user-visible options.
>
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

I don't think this is trivial.

> Modified: trunk/coreboot-v2/src/Kconfig
> ===================================================================
> --- trunk/coreboot-v2/src/Kconfig	2009-10-15 14:23:33 UTC (rev 4779)
> +++ trunk/coreboot-v2/src/Kconfig	2009-10-15 17:49:07 UTC (rev 4780)
> @@ -239,12 +243,27 @@
> 
>  config HAVE_ACPI_TABLES
>  	bool
> +	help
> +	  This variable specifies whether a given board has ACPI table
> support.
> +	  It is usually set in mainboard/*/Kconfig.
> +	  Whether or not the ACPI tables are actually generated by coreboot
> +	  is configurable by the user via GENERATE_ACPI_TABLES.

I think comments, not help text is the correct place to put comments about
CONFIG variables that will never show up in a menu.

Maybe some of it should just go into documentation/.

Thanks,
Myles





More information about the coreboot mailing list