[coreboot] [PATCH] Support for MSI MS-6156
uwe at hermann-uwe.de
Tue Oct 13 21:27:17 CEST 2009
On Tue, Oct 13, 2009 at 12:09:26PM -0600, Myles Watson wrote:
> On Tue, Oct 13, 2009 at 12:01 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> > As everyone is committing new boards today, I don't want to be left behind.
> > So here goes one more board for today (yet-another-440BX).
> > Boot-tested to a Linux prompt successfully.
> Looks good. Only picky things:
> 1. You used spaces for indentation instead of tabs in devicetree.cb
> It looks good, but I think it's good to be standard.
Yes, but I'd like to change that standard to "two spaces" in all
devicetree.cb files. Actually I sneaked in just that in all the boards
I added the last three years or so, and nobody noticed/complained ;-)
The Config.lb/devicetree.cb files can get _very_ convoluted and very
deeply nested, and one TAB for indentation (plus a comment on many
lines) make it _way_ to wide (definately lots more than 80 characters)
for my taste on many boards. Using two spaces looks much cleaner and
more readable in this case.
(This is an exception! I'm not proposing to do the same in C code or
the like. Only devicetree.cb!)
> > Kconfig only, I didn't bother adding oldconfig files anymore.
> 2. The downside is that you don't get run with abuild, so if someone
> breaks the build you won't know. Of course it's similar enough to
> other boards that most likely it won't happen.
> Acked-by: Myles Watson <mylesgw at gmail.com>
Thanks, r4767. I added Config.lb et al for now to keep it in abuild,
but it shouldn't be required much longer, oldconfig will soon go away.
http://www.hermann-uwe.de | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot