[coreboot] [PATCH] Filter out a few more

Myles Watson mylesgw at gmail.com
Tue Oct 13 14:39:05 CEST 2009


> Am Montag, den 12.10.2009, 13:58 -0600 schrieb Myles Watson:
> > Signed-off-by: Myles Watson <mylesgw at gmail.com>
> 
> +       -e "/^CONFIG_HAVE_MP_TABLE / d" \
> +       -e "/^CONFIG_HAVE_PIRQ_TABLE / d" \
> +       -e "/^CONFIG_HAVE_ACPI_TABLES / d" \
> Why do you want to exclude these from comparison?
They are options, and they aren't selected automatically by kbuildall.
Without the distinction between HAVE_ and GEN_ it would be an error to force
boards to build all the tables they have.

> +       -e "/^CONFIG_IDE / d" \
> that one is a curious case: it seems to be about the ide stream loader
> thingy (which doesn't really exist anymore), but it seems to be
> repurposed for some IDE drivers
> In src/southbridge/intel/i82801ca/Makefile.inc:
> driver-$(CONFIG_IDE) += i82801ca_ide.o
OK.  I didn't see that.

Thanks,
Myles





More information about the coreboot mailing list