[coreboot] kbuild troubles

[Peter Stuge]

Stefan Reinauer wrote:
>> Do we change confdata.c to not include unset booleans - or do we
>> change every #ifdef to #if ? I like the latter.
>
> If we change all the #ifs code we should revert to the original
> Kconfig behavior.

Patrick Georgi wrote:
> > Do we change confdata.c to not include unset booleans - or do we
> > change every #ifdef to #if ? I like the latter.
> 
> This is changed from upstream kconfig,which doesn't set unset
> booleans, so #ifdef works.

Stefan, I read Patrick's message to say that the original Kconfig
behavior works well with #ifdef. Do you like changing to #if or
keeping #ifdef ?


> Ron convinced me that #if is better than #ifdef, for such nice
> things like
> 
> if (CONFIG_FOO) {
> }
> 
> which fit in more nicely than the separate layer of preprocessing
> statements

Why is this more nice? Since it's not really common I would be
surprised (and slightly annoyed) to not find CONFIG_FOO declared in
any source code. OK, the prefix helps, but it still looks a little
strange to me.


> (among other things).

What are the other things?


//Peter