[coreboot] [PATCH] More kconfig fixes

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 9 14:22:03 CEST 2009

On Thu, Oct 08, 2009 at 09:07:40AM -0600, Myles Watson wrote:
> > - Set CONFIG_PIRQ_ROUTE=1 for boards which have an irq_tables.c but
> >    for some reason had CONFIG_PIRQ_ROUTE=0.
> >    For EPIA-M700 I'm not sure it should be used at all, as this board has
> >    ACPI tables (?)
> I don't think we should do this, unless it's been boot tested.  If the
> default was not to use it with newconfig, it could be broken.  Right now
> we're trying to match newconfig.

Yep, converted to TODO comments for now (Except for one board which
actually set the variable first to 0, then to 1 in the same file, where
I assume the second overrides the first).

> Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks, r4749.

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

More information about the coreboot mailing list