[coreboot] [v2] r4749 - in trunk/coreboot-v2/src: . arch/i386 cpu cpu/amd/socket_F_1207 mainboard/asus/m2v-mx_se mainboard/iei/juki-511p mainboard/televideo/tc7020 mainboard/via/epia-m700 southbridge/intel/i82371eb superio/fintek superio/intel superio/ite superio/nsc superio/serverengines superio/smsc superio/via superio/winbond

svn at coreboot.org svn at coreboot.org
Fri Oct 9 13:47:21 CEST 2009


Author: uwe
Date: 2009-10-09 13:47:21 +0200 (Fri, 09 Oct 2009)
New Revision: 4749

Modified:
   trunk/coreboot-v2/src/Kconfig
   trunk/coreboot-v2/src/arch/i386/Kconfig
   trunk/coreboot-v2/src/cpu/Kconfig
   trunk/coreboot-v2/src/cpu/amd/socket_F_1207/Kconfig
   trunk/coreboot-v2/src/mainboard/asus/m2v-mx_se/Kconfig
   trunk/coreboot-v2/src/mainboard/iei/juki-511p/Options.lb
   trunk/coreboot-v2/src/mainboard/televideo/tc7020/Options.lb
   trunk/coreboot-v2/src/mainboard/via/epia-m700/Options.lb
   trunk/coreboot-v2/src/southbridge/intel/i82371eb/Kconfig
   trunk/coreboot-v2/src/superio/fintek/Kconfig
   trunk/coreboot-v2/src/superio/intel/Kconfig
   trunk/coreboot-v2/src/superio/ite/Kconfig
   trunk/coreboot-v2/src/superio/nsc/Kconfig
   trunk/coreboot-v2/src/superio/serverengines/Kconfig
   trunk/coreboot-v2/src/superio/smsc/Kconfig
   trunk/coreboot-v2/src/superio/via/Kconfig
   trunk/coreboot-v2/src/superio/winbond/Kconfig
Log:
More kconfig cleanups:

 - Use "default n" for all components that shall be "select"ed.

 - Use "0x0" instead of "0" for hex variables for clarity and to reduce
   the risk of people passing integer instead of hex values to such variables.

 - Add TODO comments for boards that have irq_tables.c but don' set
   CONFIG_HAVE_PIRQ_TABLE = 1. Someone with the hardware should test enabling.

 - ASUS M2V-MX SE doesn't have irq_tables.c so don't define
   IRQ_SLOT_COUNT in its Kconfig file.

Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acked-by: Myles Watson <mylesgw at gmail.com>



Modified: trunk/coreboot-v2/src/Kconfig
===================================================================
--- trunk/coreboot-v2/src/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -56,11 +56,11 @@
 
 config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID
 	hex
-	default 0
+	default 0x0
 
 config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID
 	hex
-	default 0
+	default 0x0
 
 config CPU_ADDR_BITS
 	int
@@ -68,7 +68,7 @@
 
 config AGP_APERTURE_SIZE
 	hex
-	default 0
+	default 0x0
 
 config XIP_ROM_BASE
 	hex
@@ -174,7 +174,7 @@
 
 config HAVE_HARD_RESET
 	bool
-	default 0
+	default n
 
 config HAVE_INIT_TIMER
 	bool

Modified: trunk/coreboot-v2/src/arch/i386/Kconfig
===================================================================
--- trunk/coreboot-v2/src/arch/i386/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/arch/i386/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -29,7 +29,7 @@
 
 config PAYLOAD_SIZE
 	hex
-	default 0
+	default 0x0
 
 config ROM_PAYLOAD_START
 	hex

Modified: trunk/coreboot-v2/src/cpu/Kconfig
===================================================================
--- trunk/coreboot-v2/src/cpu/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/cpu/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -19,7 +19,7 @@
 
 config DCACHE_RAM_GLOBAL_VAR_SIZE
 	hex
-	default 0
+	default 0x0
 
 config MAX_PHYSICAL_CPUS
 	int

Modified: trunk/coreboot-v2/src/cpu/amd/socket_F_1207/Kconfig
===================================================================
--- trunk/coreboot-v2/src/cpu/amd/socket_F_1207/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/cpu/amd/socket_F_1207/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -41,5 +41,5 @@
 
 config CDB
 	hex
-	default 0
+	default 0x0
 	depends on CPU_AMD_SOCKET_F_1207

Modified: trunk/coreboot-v2/src/mainboard/asus/m2v-mx_se/Kconfig
===================================================================
--- trunk/coreboot-v2/src/mainboard/asus/m2v-mx_se/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/mainboard/asus/m2v-mx_se/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -115,8 +115,3 @@
 	default 0x20
 	depends on BOARD_ASUS_M2V_MX_SE
 
-# FIXME?
-config IRQ_SLOT_COUNT
-	int
-	default 11
-	depends on BOARD_ASUS_M2V_MX_SE

Modified: trunk/coreboot-v2/src/mainboard/iei/juki-511p/Options.lb
===================================================================
--- trunk/coreboot-v2/src/mainboard/iei/juki-511p/Options.lb	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/mainboard/iei/juki-511p/Options.lb	2009-10-09 11:47:21 UTC (rev 4749)
@@ -69,10 +69,10 @@
 ##
 ## Build code to export a programmable irq routing table
 ##
+# FIXME: There's an irq_tables.c file, but CONFIG_HAVE_PIRQ_TABLE is 0.
 default CONFIG_HAVE_PIRQ_TABLE=0
 default CONFIG_IRQ_SLOT_COUNT=2
 default CONFIG_PIRQ_ROUTE=1
-#object irq_tables.o
 
 ##
 ## Build code to export a CMOS option table

Modified: trunk/coreboot-v2/src/mainboard/televideo/tc7020/Options.lb
===================================================================
--- trunk/coreboot-v2/src/mainboard/televideo/tc7020/Options.lb	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/mainboard/televideo/tc7020/Options.lb	2009-10-09 11:47:21 UTC (rev 4749)
@@ -70,8 +70,6 @@
 default CONFIG_GX1_VIDEOMODE = 0
 default CONFIG_SPLASH_GRAPHIC = 1
 default CONFIG_VIDEO_MB = 2
-default CONFIG_HAVE_PIRQ_TABLE=0
-default CONFIG_PIRQ_ROUTE=1
 
 default CONFIG_ROM_SIZE = 256 * 1024
 default CONFIG_MAINBOARD_VENDOR = "TeleVideo"
@@ -82,6 +80,7 @@
 default CONFIG_UDELAY_TSC = 1
 default CONFIG_TSC_X86RDTSC_CALIBRATE_WITH_TIMER2 = 1
 default CONFIG_HAVE_PIRQ_TABLE = 1
+default CONFIG_PIRQ_ROUTE=1
 default CONFIG_IRQ_SLOT_COUNT = 3	# Soldered NIC, internal USB, mini PCI slot
 default CONFIG_HAVE_OPTION_TABLE = 0
 default CONFIG_ROM_IMAGE_SIZE = 64 * 1024

Modified: trunk/coreboot-v2/src/mainboard/via/epia-m700/Options.lb
===================================================================
--- trunk/coreboot-v2/src/mainboard/via/epia-m700/Options.lb	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/mainboard/via/epia-m700/Options.lb	2009-10-09 11:47:21 UTC (rev 4749)
@@ -116,6 +116,7 @@
 default CONFIG_UDELAY_TSC = 1
 default CONFIG_TSC_X86RDTSC_CALIBRATE_WITH_TIMER2 = 1
 default CONFIG_HAVE_HARD_RESET = 0
+# TODO: There is an irq_tables.c file, should it be used?
 default CONFIG_HAVE_PIRQ_TABLE = 0
 default CONFIG_IRQ_SLOT_COUNT = 13
 default CONFIG_HAVE_ACPI_TABLES = 1

Modified: trunk/coreboot-v2/src/southbridge/intel/i82371eb/Kconfig
===================================================================
--- trunk/coreboot-v2/src/southbridge/intel/i82371eb/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/southbridge/intel/i82371eb/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,3 +1,4 @@
 config SOUTHBRIDGE_INTEL_I82371EB
 	bool
+	default n
 

Modified: trunk/coreboot-v2/src/superio/fintek/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/fintek/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/fintek/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,2 +1,3 @@
 config SUPERIO_FINTEK_F71805F
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/intel/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/intel/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/intel/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,2 +1,3 @@
 config SUPERIO_INTEL_I3100
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/ite/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/ite/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/ite/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,14 +1,21 @@
 config SUPERIO_ITE_IT8661F
 	bool
+	default n
 config SUPERIO_ITE_IT8671F
 	bool
+	default n
 config SUPERIO_ITE_IT8673F
 	bool
+	default n
 config SUPERIO_ITE_IT8705F
 	bool
+	default n
 config SUPERIO_ITE_IT8712F
 	bool
+	default n
 config SUPERIO_ITE_IT8716F
 	bool
+	default n
 config SUPERIO_ITE_IT8718F
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/nsc/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/nsc/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/nsc/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,18 +1,27 @@
 config SUPERIO_NSC_PC8374
 	bool
+	default n
 config SUPERIO_NSC_PC87309
 	bool
+	default n
 config SUPERIO_NSC_PC87351
 	bool
+	default n
 config SUPERIO_NSC_PC87360
 	bool
+	default n
 config SUPERIO_NSC_PC87366
 	bool
+	default n
 config SUPERIO_NSC_PC87417
 	bool
+	default n
 config SUPERIO_NSC_PC87427
 	bool
+	default n
 config SUPERIO_NSC_PC97307
 	bool
+	default n
 config SUPERIO_NSC_PC97317
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/serverengines/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/serverengines/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/serverengines/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,2 +1,3 @@
 config SUPERIO_SERVERENGINES_PILOT
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/smsc/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/smsc/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/smsc/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,12 +1,18 @@
 config SUPERIO_SMSC_FDC37M60X
 	bool
+	default n
 config SUPERIO_SMSC_LPC47B272
 	bool
+	default n
 config SUPERIO_SMSC_LPC47B397
 	bool
+	default n
 config SUPERIO_SMSC_LPC47M10X
 	bool
+	default n
 config SUPERIO_SMSC_LPC47N217
 	bool
+	default n
 config SUPERIO_SMSC_SMSCSUPERIO
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/via/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/via/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/via/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,2 +1,3 @@
 config SUPERIO_VIA_VT1211
 	bool
+	default n

Modified: trunk/coreboot-v2/src/superio/winbond/Kconfig
===================================================================
--- trunk/coreboot-v2/src/superio/winbond/Kconfig	2009-10-08 20:17:14 UTC (rev 4748)
+++ trunk/coreboot-v2/src/superio/winbond/Kconfig	2009-10-09 11:47:21 UTC (rev 4749)
@@ -1,18 +1,27 @@
 config SUPERIO_WINBOND_W83627DHG
 	bool
+	default n
 config SUPERIO_WINBOND_W83627EHG
 	bool
+	default n
 config SUPERIO_WINBOND_W83627HF
 	bool
+	default n
 config SUPERIO_WINBOND_W83627THF
 	bool
+	default n
 config SUPERIO_WINBOND_W83627THG
 	bool
+	default n
 config SUPERIO_WINBOND_W83627UHG
 	bool
+	default n
 config SUPERIO_WINBOND_W83697HF
 	bool
+	default n
 config SUPERIO_WINBOND_W83977F
 	bool
+	default n
 config SUPERIO_WINBOND_W83977TF
 	bool
+	default n





More information about the coreboot mailing list