[coreboot] [v2] r4743 ..

[Peter Stuge]

svn at coreboot.org wrote:
> +++ trunk/coreboot-v2/src/cpu/amd/model_lx/Kconfig	2009-10-08 14:31:56 UTC (rev 4743)
> @@ -0,0 +1,4 @@
> +config CPU_AMD_LX
> +	bool
> +	default n
> +

It would be nice to have GEODE in this name. Also an extra blank line
snuck in.


> +++ trunk/coreboot-v2/src/cpu/amd/sc520/Kconfig	2009-10-08 14:31:56 UTC (rev 4743)
> @@ -0,0 +1,4 @@
> +config CPU_AMD_SC520
> +	bool
> +	default n
> +

Maybe ELAN here?


> +config BOARD_IEI_PCISA_LX_800_R10
> +	bool "PCISA lx-800 r10"

These new board names seem to be mostly lowercase, which isn't really
right. I'll fix the ones I know about.


> +++ trunk/coreboot-v2/src/mainboard/iei/pcisa-lx-800-r10/Makefile.inc	2009-10-08 14:31:56 UTC (rev 4743)
> @@ -0,0 +1,31 @@
> +driver-y += mainboard.o
> +
> +# Needed by irq_tables and mptable and acpi_tables.
> +obj-$(CONFIG_HAVE_PIRQ_TABLE) += irq_tables.o
> +
> +# This is part of the conversion to init-obj and away from included code.
> +
> +initobj-y += crt0.o
> +# FIXME in $(top)/Makefile
> +crt0-y += ../../../../src/cpu/x86/16bit/entry16.inc
> +crt0-y += ../../../../src/cpu/x86/32bit/entry32.inc
> +crt0-y += ../../../../src/cpu/x86/16bit/reset16.inc
> +crt0-y += ../../../../src/arch/i386/lib/id.inc
> +crt0-y += ../../../../src/cpu/amd/model_lx/cache_as_ram.inc
> +crt0-y += auto.inc
> +
> +ldscript-y += ../../../../src/arch/i386/init/ldscript_fallback_cbfs.lb
> +ldscript-y += ../../../../src/cpu/x86/16bit/entry16.lds
> +ldscript-y += ../../../../src/cpu/x86/16bit/reset16.lds
> +ldscript-y += ../../../../src/arch/i386/lib/id.lds
> +ldscript-y += ../../../../src/arch/i386/lib/failover.lds
> +
> +ifdef POST_EVALUATION
> +
> +$(obj)/mainboard/$(MAINBOARDDIR)/auto.inc: $(src)/mainboard/$(MAINBOARDDIR)/cache_as_ram_auto.c
> +	$(CC) $(DISTRO_CFLAGS) $(CFLAGS) $(CPPFLAGS) $(DEBUG_CFLAGS) -I$(src) -I. -c -S  $(src)/mainboard/$(MAINBOARDDIR)/cache_as_ram_auto.c -o $@
> +	perl -e 's/\.rodata/.rom.data/g' -pi $@
> +	perl -e 's/\.text/.section .rom.text/g' -pi $@
> +
> +endif
> +

This looks similar if not identical among very many boards. Can they
be folded together? Sorry if I am nagging about this.


//Peter