[coreboot] [PATCH] Major CONFIG_IRQ_TABLE_COUNT fixing and cleanups
Uwe Hermann
uwe at hermann-uwe.de
Wed Oct 7 23:55:50 CEST 2009
On Wed, Oct 07, 2009 at 01:42:12PM -0600, Myles Watson wrote:
> On Wed, Oct 7, 2009 at 1:32 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> > See patch.
> Index: src/mainboard/intel/xe7501devkit/irq_tables.c
> ===================================================================
> --- src/mainboard/intel/xe7501devkit/irq_tables.c (Revision 4738)
> +++ src/mainboard/intel/xe7501devkit/irq_tables.c (Arbeitskopie)
> @@ -20,7 +20,7 @@
> const struct irq_routing_table intel_irq_routing_table = {
> PIRQ_SIGNATURE,
> PIRQ_VERSION,
> - 32 + 12*sizeof(struct irq_info), // Size of this struct in bytes
> + 32 + 16 * CONFIG_IRQ_SLOT_COUNT, // Size of this struct in bytes
>
> I like the sizeof. It removes one magic number.
Yeah, might be worth considering, but we should do a mass-change in all
files then. Probably low-priority right now, though.
> Acked-by: Myles Watson <mylesgw at gmail.com>
Thanks, r4739.
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot
mailing list