[coreboot] [PATCH] kconfig support for all GX1 boards

ron minnich rminnich at gmail.com
Sun Oct 4 18:26:47 CEST 2009

--- src/mainboard/Makefile.romccboard.inc	(Revision 4718)
+++ src/mainboard/Makefile.romccboard.inc	(Arbeitskopie)
@@ -26,9 +26,16 @@
 crt0-y += ../../../../src/arch/i386/lib/id.inc
 crt0-y += failover.inc
 crt0-y += ../../../../src/cpu/x86/fpu/enable_fpu.inc
+ifeq ($(CONFIG_CPU_AMD_GX1),y)
+crt0-y += ../../../../src/cpu/amd/model_gx1/cpu_setup.inc
+crt0-y += ../../../../src/cpu/amd/model_gx1/gx_setup.inc
+crt0-y += auto.inc
 crt0-y += ../../../../src/cpu/x86/mmx/enable_mmx.inc
 crt0-y += auto.inc
 crt0-y += ../../../../src/cpu/x86/mmx/disable_mmx.inc

As you know I'd rather see this done differently but I need to put the
select MMX
in all those CPUs that support it. So I will change this later when I
can, or someone else can. Here's what it ought to look like:

+crt0-$(CONFIG_CPU_AMD_GX1) += ../../../../src/cpu/amd/model_gx1/cpu_setup.inc
+crt0-$(CONFIG_CPU_AMD_GX1) += ../../../../src/cpu/amd/model_gx1/gx_setup.inc
 crt0-$(CONFIG_MMX) += ../../../../src/cpu/x86/mmx/enable_mmx.inc
 crt0-$(CONFIG_SSE) += ../../../../src/cpu/x86/sse/enable_sse.inc
 crt0-y += auto.inc
 crt0-$(CONFIG_SSE) += ../../../../src/cpu/x86/sse/enable_sse.inc
 crt0-$(CONFIG_MMX) += ../../../../src/cpu/x86/mmx/disable_mmx.inc

But, as said,for each CPU that supports SSE and MMX, we have to add
the right select statements.

But this is such fine work that it is:

Acked-by: Ronald G. Minnich <rminnich at gmail.com>

thanks, really nice job


More information about the coreboot mailing list