[coreboot] [PATCH]remove pre-cbfs build system, pt. 3

Patrick Georgi patrick at georgi-clan.de
Sun Oct 4 16:34:59 CEST 2009


Am Sonntag, den 04.10.2009, 16:24 +0200 schrieb Peter Stuge:
> Might be wise to wait for some testing, but I really like this!
I'll wait a bit more.

> >  uses CONFIG_ROM_IMAGE_SIZE
> >  uses CONFIG_ROM_SECTION_SIZE
> >  uses CONFIG_ROM_SECTION_OFFSET
> 
> What about these ones? They are also affected by cbfs, right?
I'm not done yet :-)

> Please delete the comment and a blank line too.
Right, thanks

> > --- src/arch/i386/lib/failover.lds	(Revision 4716)
> > +++ src/arch/i386/lib/failover.lds	(Arbeitskopie)
> > @@ -1 +1 @@
> > -	__normal_image = (CONFIG_ROM_PAYLOAD_START & 0xfffffff0) - 8;
> > +	__normal_image = (CONFIG_ROMBASE & 0xfffffff0) - 8;
> 
> What do these files do, exactly? What is the -8 about?
They define the symbols used in linking: failover does a
jmp __normal_image
to get to normal, this one calculates the address: 8 bytes before the
start of the current image in this case, similar for the others.
reset32.{inc,lds} creates a jump instruction there, jumping to the real
start address.


Patrick





More information about the coreboot mailing list