[coreboot] [PATCH]fix various vgabios.c copies in light of CBFS

Patrick Georgi patrick at georgi-clan.de
Sat Oct 3 16:48:32 CEST 2009


there were a couple of copies of vgabios.c that looked for the option
rom image at fixed addresses (usually begin of flash), which is not the
supported way of doing things anymore.

As this patch removes the non-CBFS capability, I'd commit it right after
the removal of non-CBFS support this evening (in ~3 hours), as non-CBFS
support isn't necessary anymore at that point.

Of course, the duplication should be eliminated, as well as (some of)
the rom_address entries in Config.lb and devicetree.cb for the boards.

It might also be worthwhile to investigate if src/devices/pci_rom.c
couldn't be used for the option rom loading. Just using dev->rom_address
didn't work on my board, but this fix was good enough for me for now.

The change is the same in all vgabios.c files, it's boot tested on cx700
(via/vt8454c), via/epia-m and artecgroup/dbe61 are build tested.
for cn400, via/epia-n built,
for cn700, via/epia-cn built,
for vx800, via/epia-m700 built

Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20091003-1-vgabios-in-cbfs
Type: text/x-patch
Size: 3948 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091003/ff1b8d41/attachment.diff>

More information about the coreboot mailing list