[coreboot] [PATCH]Remove non-CBFS

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Thu Oct 1 00:08:13 CEST 2009


On 30.09.2009 23:08, Stefan Reinauer wrote:
> On Sep 30, 2009, at 22:56, Peter Stuge <peter at stuge.se> wrote:
>> Patrick Georgi wrote:
>>> attached patch removes:
>>> - CONFIG_CBFS
>>> - stream boot code
>>
>> Wasn't this used for accessing large flash on m57sli?
>
> Yes.
>
> Anyone with such a setup willing to fix CBFS for that?

I don't have such a setup, but I remember the discussion about
supporting this for LAR in v3 and back then it was the consensus that
such boards would simply not be ported to v3. Given that v2 now has
CBFS, we need to either abandon large flash on M57SLI and similar boards
or fix CBFS somehow.

The horrible way out is to use accessor functions for every flash access
made by CBFS code. It also means you get to write your own streaming
version of memcmp, strstr, strlen etc.
The easy way out is to simply copy all of flash to RAM, then walk the
copy in RAM. It's a bit inefficient because you have to copy the whole
flash chip to RAM, but the code stays readable. Of course RAMinit and
bootblock have to be in the always-mapped region of the flash chip.


>> And does it have anything to do with the serial transfer stuff?
>> (Xmodem)
>
> Not possible anymore with CBFS.. Maybe we should make a minipayload
> for the functionality?

Interfacing the minipayload is probably going to be more pain than
simply linking in the xmodem code and calling it if all other options fail.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list