[coreboot] [PATCH] The buzzer of TechNexion TIM-5690.

Bao, Zheng Zheng.Bao at amd.com
Wed Nov 25 08:49:04 CET 2009


R4954.

 

 

________________________________

From: Libra Li [mailto:librali1977 at gmail.com] 
Sent: Wednesday, November 25, 2009 2:19 PM
To: Bao, Zheng
Cc: coreboot
Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.

 

Hi, 

    I had fixing non-ascii characters in the comments.
    Thanks.

    Signed-off: Libra Li <libra.li <http://libra.li/> @technexion.com
<http://technexion.com/> >



2009/11/25 Bao, Zheng <Zheng.Bao at amd.com>

I haven't apply your patch, but in your patch,
line 140, 150, 159, 166, 175, 185, 194,
have those chars.

You can use the perl script to detect the non-ascii chars. I sense there
should be another better way.

#!/usr/bin/perl

my($content, $len);

open(FILE, "< tim5690_buzzer_2.patch") || die "Unable to open file
small. <$!>\n";

while( chomp($content = <FILE>) ) {
   $len = length($content);
   for( $i = 0; $i < $len; $i++ ) {
       if( ord(substr($content, $i, 1)) > 127 )
       {
           print "$content\n";
           last;
       }
   }
}
close(FILE);

exit 0
~





-----Original Message-----
From: coreboot-bounces at coreboot.org
[mailto:coreboot-bounces at coreboot.org] On Behalf Of Bao, Zheng
Sent: Wednesday, November 25, 2009 11:32 AM
To: Libra Li
Cc: coreboot
Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.

There is some non-ascii characters in the comments. Please fix it.
After that,

Acked-by: Zheng Bao <zheng.bao at amd.com>

Zheng
________________________________________
From: coreboot-bounces at coreboot.org
[mailto:coreboot-bounces at coreboot.org] On Behalf Of Libra Li
Sent: Wednesday, November 25, 2009 9:46 AM
To: Myles Watson
Cc: coreboot
Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.

Hi, Myles, Coreboot,

    I had change EARLY_STAGE into __PRE_RAM__. It's okay.
    Thanks.

    Signed-off: Libra Li <libra.li at technexion.com>

2009/11/25 Myles Watson <mylesgw at gmail.com>
2009/11/24 Libra Li <librali1977 at gmail.com>:
> Hi,
>
>     This patch is buzzer function of TechNexion TIM-5690.
>     That isn't everyone needs. So I don't put in public areas.
>     Thanks.
>
>     Signed-off: Libra Li <libra.li at technexion.com>
Could you use __PRE_RAM__ instead of EARLY_STAGE?  Does it mean
something different?

Thanks,
Myles




--
coreboot mailing list: coreboot at coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot



 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091125/32add5eb/attachment.html>


More information about the coreboot mailing list