[coreboot] [PATCH] Drop drivers/pci/onboard

Myles Watson mylesgw at gmail.com
Fri Nov 6 22:02:06 CET 2009

On Fri, Nov 6, 2009 at 1:14 PM, Myles Watson <mylesgw at gmail.com> wrote:

> On Fri, Nov 6, 2009 at 12:56 PM, Myles Watson <mylesgw at gmail.com> wrote:
>> On Fri, Nov 6, 2009 at 12:41 PM, Peter Stuge <peter at stuge.se> wrote:
>>>  Myles Watson wrote:
>>> > > > PCI onboard was only used for ROM images at fixed offsets in
>>> > > > flash.  Now that we have CBFS, there is no use for it.
>>>  But what about the PCI device ids which are being taken out of the
>>> device tree? Are they guaranteed to be discovered through automatic
>>> scanning?
>> Yes.  If the couldn't be probed, they would have been disabled even though
>> they were found in the tree.
>> I wonder a little about the on_mainboard flag.  It's possible that some of
>> these devices would have had that flag set if they didn't need to have a
>> ROM.  I don't know of a good way to automatically figure out which devices
>> that would apply to.
> The rest of the story :)
> The on_mainboard flag gets used to set subsystem IDs and
I put all the devices back in the tree.  So they show up in static.c like
they should, they just don't have the onboard driver any more.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091106/40aae7c0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no_onboard.diff
Type: text/x-patch
Size: 102060 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091106/40aae7c0/attachment.diff>

More information about the coreboot mailing list