[coreboot] [PATCH] Drop all pre-CBFS rom_address entries in Config.lb/devicetree.cb

Myles Watson mylesgw at gmail.com
Thu Nov 5 18:42:35 CET 2009

On Wed, Oct 28, 2009 at 2:18 PM, Myles Watson <mylesgw at gmail.com> wrote:

> On Wed, Oct 28, 2009 at 1:58 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
>> See patch.
> I think it would be nice to figure out what we do with the "onboard" device
> at the same time.
Ping.  I think this patch is an improvement, but I didn't want the
opportunity to remove more dead code pass by.  Any comments?

 from src/drivers/pci/onboard.c:
> static void onboard_enable(device_t dev)
> {
>     struct drivers_pci_onboard_config *conf;
>         conf = dev->chip_info;
>     dev->rom_address = conf->rom_address;
> }
> Does it make sense to change ROM handling so that only "onboard" devices
> can have their ROMs run?  That's the way it used to be, right?
> Otherwise, maybe we don't need onboard anymore at all?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091105/13a2085c/attachment.html>

More information about the coreboot mailing list