[coreboot] [PATCH] cleanup x86emu without yabel
stepan at coresystems.de
Thu Nov 5 17:57:59 CET 2009
Myles Watson wrote:
> +#ifdef CONFIG_COREBOOT_V2
> + dev = dev_find_device(X86_DX, X86_CX, dev);
> This looks wrong. I know it really isn't part of the patch, but isn't
> CONFIG_COREBOOT_V2 always defined? I guess it isn't in v3...
It should be always defined in v2, and never in v2... Not sure if things
changed meanwhile, but that part of the code is not new, just copied..
We could make v2 more similar to v3
svn mv src/include/console/* src/include
if you feel like we should drop the define.
(Or we just drop the define since x86emu is no longer shared with v3)
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot