[coreboot] [PATCH] Table cleanup continued

Myles Watson mylesgw at gmail.com
Tue May 26 20:29:27 CEST 2009

On Tue, May 26, 2009 at 12:21 PM, Stefan Reinauer <stepan at coresystems.de> wrote:
> On 26.05.2009 20:14 Uhr, Myles Watson wrote:
> I'm still worried about someone changing the alignment of the rdsp and
> breaking the high tables code.
> I don't understand?
Since the code in tables.c depends on the implementation of
acpi_write_tables, it will be easy to break.

> I don't think spreading out a generic piece of code to each and every
> mainboard with ACPI is a terribly good idea.

> Can this be solved within tables.c?
No. The best way to do it is to factor out acpi_write_tables, but I
don't have the time to do that right.  The most specific code is for
kontron and I don't have the hardware.


More information about the coreboot mailing list