[coreboot] [PATCH] flashrom: Handle WREN and EWSR failure gracefully on ICH/VIA SPI

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri May 15 02:58:16 CEST 2009

On 15.05.2009 02:45, Cristi Magherusan wrote:
> On Thu, 2009-05-14 at 22:51 +0800, FENG Yu Ning wrote:
>> Carl-Daniel Hailfinger wrote:
>>> Until the ICH SPI driver can handle preopcodes as standalone opcodes, we
>>> should handle such special opcode failure gracefully on ICH and
>>> compatible chipsets.
>> Acked-by: FENG Yu Ning <fengyuning1984 at gmail.com>
>> iirc, Rudolf came to similar solution before, and I tried to hold it
>> back. That might be a wrong decision.
>> I still don't like that much. However, I realize that personal taste
>> is a bad reason to hold back a workaround for a long time. I don't
>> want to make a wrong decision once more.

I'm not too happy about the workaround either. The SPI layer needs some
design changes in the future to better handle this.

>> It seems not many are interested in it. Here is my ack.
>> yu ning
> Tested and works on real hardware - Asus M2V-MX-SE with SST
> SST25VF032B" (4096 KB) SPI flash
> Acked-by: Cristi Magherusan <cristi.magherusan at net.utcluj.ro>

Thank you both for reviewing!

Committed in r514.



More information about the coreboot mailing list