[coreboot] [PATCH] Table code cleanup

Bao, Zheng Zheng.Bao at amd.com
Thu May 14 08:13:40 CEST 2009

I tried tables.diff and high_low.diff. The patch was somehow rejected
and I had patched them manually. The kernel still reports ACPI table

Please check it. And, it would be best for me if the patches based on
the latest version are provided.


-----Original Message-----
From: coreboot-bounces at coreboot.org
[mailto:coreboot-bounces at coreboot.org] On Behalf Of Myles Watson
Sent: Thursday, May 14, 2009 6:02 AM
To: coreboot
Subject: [coreboot] [PATCH] Table code cleanup

I didn't understand what was going on in tables.c, and it seemed a
little fragile.

These three patches try to help that out.  I would only recommend the
first two, but all three is closer to maintaining the functionality we

When you're reviewing, it will be helpful to note that rom_tables_* ==
LOW_TABLES, high_tables_* == HIGH_TABLES, and low_tables==
coreboot-specific very low tables.

These patches are abuild tested and boot tested on Tyan s2892, qemu, and

Add comments.
Remove ACPI-specific code.
Align low_table_end after gdt (so it matches high_table_end).
Correct "New low_table_end..." line in coreboot_table.c.

Factor out common code for writing tables.

If we need to have the tables written both times we can do something
like this.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

More information about the coreboot mailing list