[coreboot] [PATCH] flashrom: Differentiate SPI errors
c-d.hailfinger.devel.2006 at gmx.net
Wed May 13 13:40:32 CEST 2009
On 12.05.2009 17:14, Uwe Hermann wrote:
> On Mon, May 11, 2009 at 07:40:39PM +0200, Carl-Daniel Hailfinger wrote:
>> There are various reasons why a SPI command can fail. Among others, I
>> have seen the following problems:
>> - The SPI opcode is not supported by the controller. ICH-style
>> controllers exhibit this if SPI config is locked down.
>> - The address in in a prohibited area. This can happen on ICH for any
>> access (BBAR) and for writes in chipset write protected areas.
>> - There is no SPI controller.
>> Introduce separate error codes for unsupported opcode and prohibited
>> Add the ability to adjust REMS and RES addresses to the minium supported
>> read address with the help of spi_get_valid_read_addr(). That function
>> needs to call SPI controller specific functions like reading BBAR on ICH.
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
Thanks, committed in r500.
More information about the coreboot