[coreboot] [PATCH] fix the XIP size and fallback computations for M2V-MX SE

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon May 11 03:15:05 CEST 2009

It seems I forgot to send this mail although it sat finished in my
drafts folder. Sorry.

On 02.05.2009 23:54, Rudolf Marek wrote:
> It seems I'm quite tired to formulate the description of the patch
> accurately I
> hope it is understandable somehow.
> Following patch fixes the XIP computation issue. I removed the normal
> image
> because it was not working anyway (it was hardcoded) and because it
> allows me to
> fix the XIP base to something sane (and use generic computation and
> approach)
> This board is bit tricky because until now it required the VGA BIOS on
> the flash
> start. XIP will work with 64KB aligned base, therefore the VGA ROM
> image must be
> aligned too to 64KB.
> Third reason is that now it makes 384KB for additional ROMs and
> payload - plenty
> of space for CBFS fun ;)
> Now it uses generic _ROMBASE etc computation which is nice too.
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

The Config.lb part is awesome and I really appreciate it because I
didn't dare to convert that file to the ROM size calculation include file.
The rest looks good as well, but I'm not an expert for that code.

Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


More information about the coreboot mailing list