[coreboot] changes to cbfstool to support more efficient rom walking

Myles Watson mylesgw at gmail.com
Fri May 8 21:08:33 CEST 2009

On Fri, May 8, 2009 at 9:53 AM, ron minnich <rminnich at gmail.com> wrote:
> I realized during the discussion that there is a fundamental
> improvement we can make to cbfstool. This change I am detailing is
> compatible with existing coreboot libraries. I describe it below and
> attach the patch.
> I have made a very simple mod to cbfstool that is compatible with the
> src/lib/ code in coreboot. I.e. the tool changes but the coreboot code
> does not.

I think it is a step in the right direction.  Could you add the
function prototype to cbfstool.h?

Acked-by: Myles Watson <mylesgw at gmail.com>


Index: cbfstool/cbfstool.h
--- cbfstool.orig/cbfstool.h	2009-05-08 13:07:42.000000000 -0600
+++ cbfstool/cbfstool.h	2009-05-08 13:07:43.000000000 -0600
@@ -71,6 +71,7 @@
 struct cbfs_file *rom_find_first(struct rom *);
 struct cbfs_file *rom_find_next(struct rom *, struct cbfs_file *);
 int rom_add(struct rom *rom, const char *name, void *, int size, int type);
+int rom_set_header(struct rom *rom, struct cbfs_file *c, const char
*name, int size, int type);
 int rom_extract(struct rom *rom, const char *name, void **buf, int *size);
 int rom_remove(struct rom *rom, const char *name);
 int rom_used_space(struct rom *rom);

More information about the coreboot mailing list