[coreboot] [PATCH] flashrom: Check return codes of spi_write_enable

FENG Yu Ning fengyuning1984 at gmail.com
Thu May 7 18:25:58 CEST 2009


Carl-Daniel wrote:
> Until the ICH SPI driver can handle preopcodes as standalone opcodes ...

I don't like ICH's preop design either. However, I think we shall
write software following the hardware design's policy. Trying to
compensate defect of hardware design costs and probably not gains
more.

ICH SPI tries to be "smarter" than other chipsets. We may consider
transfer control to ICH SPI driver as early as possible, leaving more
decision to be done by the ICH SPI driver instead of the generic SPI
driver layer.

My two cents.

yu ning




More information about the coreboot mailing list