[coreboot] r4233/4234 broke h8dme (serial corruption + hang)
ward at gnu.org
Tue May 5 16:02:35 CEST 2009
On Tue, May 05, 2009 at 03:05:58PM +0200, Patrick Georgi wrote:
> Am 01.05.2009 23:15, schrieb Ward Vandewege:
>> It seems r4233/4234 broke the tree for h8dme (k8). Here's how my boot hangs,
>> note the corruption in the serial log:
> The "corruption" is fine - it's just both cores chatting at the same time.
> I made a small mistake in the refactoring of copy_and_run that affected
> only the coreboot_apc codepath (which I can't test).
> While the copy_and_run_core function takes a "dst" argument, and
> compresses to that location, it jumped to a hardcoded entry point of
> _iseg - which works for all scenarios but coreboot_apc.
> With the change, the dst value is used for all cases.
> Please try attached patch which should fix it. It's tested to run in the
> non-APC codepath and is
Thanks, tested on h8dme and this fixes the problem.
> Signed-off-by: Patrick Georgi <patrick.georgi at coresystems.de>
Acked-by: Ward Vandewege <ward at gnu.org>
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator
More information about the coreboot