[coreboot] [PATCH]i82830 custom vga driver

Joseph Smith joe at settoplinux.org
Fri May 1 13:40:16 CEST 2009

On Fri, 01 May 2009 11:22:24 +0200, Stefan Reinauer <stepan at coresystems.de>
> On 01.05.2009 6:06 Uhr, Myles Watson wrote:
>> On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith <joe at settoplinux.org>
> wrote:
>>> This patch allows a custom vga driver that will give the flexibility to
> run
>>> code after vga is initialized for tv-out. It is one of many patches to
>>> come, including code to manipulate the graphics mmio registers, enable
> the
>>> graphics i2c data lines, and tv encoder drivers.
>> Should it be conditionally included via a config option?  Are there
>> other boards with the same chipset that won't want to use this TV-out
>> initialization?
> Please, no more CONFIG flags.
> - If it's a property of the board / northbridge, it should be a variable
> in the chip's config structure
Ok that sound better.
> - there's no real code in that function, so there's not much sense to
> make anything conditional yet.
Right, it doesn't do anything extra yet, I am just setting the stage for
what is to come, because vga.c is going to be where all the code is called
from, kind of like a sub main() if you will.

Joseph Smith

More information about the coreboot mailing list