[coreboot] [PATCH] i82801xx IRQ Fix Up

[Joseph Smith]

On Fri, 01 May 2009 11:15:41 +0200, Stefan Reinauer <stepan at coresystems.de>
wrote:
> On 01.05.2009 3:32 Uhr, Joseph Smith wrote:
>> This is a patch to use another IRQ besides IRQ12 to fix conflicts with
>> i8042 - PS/2 Mouse, most commonly assigned IRQ12 by the SuperIO. It took
> me
>> this long to catch this because I usually use a USB mouse.
>>
> Good spot!
> 
>> Index: src/southbridge/intel/i82801xx/i82801xx_lpc.c
>> ===================================================================
>> --- src/southbridge/intel/i82801xx/i82801xx_lpc.c	(revision 4240)
>> +++ src/southbridge/intel/i82801xx/i82801xx_lpc.c	(working copy)
>> @@ -58,14 +58,16 @@
>>   */
>>
>>  #define PIRQA 0x03
>> -#define PIRQB 0x05
>> -#define PIRQC 0x06
>> -#define PIRQD 0x07
>> -#define PIRQE 0x09
>> -#define PIRQF 0x0A
>> -#define PIRQG 0x0B
>> -#define PIRQH 0x0C
>> +#define PIRQB 0x04
>> +#define PIRQC 0x05
>> +#define PIRQD 0x06
>> +#define PIRQE 0x07
>> +#define PIRQF 0x09
>> +#define PIRQG 0x0A
>> +#define PIRQH 0x0B
>>
> 
> 
> Hard coding these looks like it could work on one board and fail on
> another. For the i82801gx I added these to the chip's config structure,
> so they can be set in the device tree of the mainboard's config.lb.
> Maybe that's what you want here, too?
> 
That's awsome. I never noticed that. Yes we really should setup all boards
like this and get rid of these defines in i82801xx_lpc.c. I never really
liked it. One question, where do you have the "pirqx_routing" defined? We
should really work on a patch for all mainboards that use i82801xx.

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org