[coreboot] [PATCH] Fix the NULL dev resource usage

Myles Watson mylesgw at gmail.com
Wed Mar 25 19:29:05 CET 2009

> -----Original Message-----
> From: coreboot-bounces at coreboot.org [mailto:coreboot-bounces at coreboot.org]
> On Behalf Of Rudolf Marek
> Sent: Wednesday, March 25, 2009 12:16 PM
> To: Coreboot
> Subject: [coreboot] [PATCH] Fix the NULL dev resource usage
> Hash: SHA1
> Hello,
> During the suspend/resume programming I came to an issue that first 4KB of
> memory must be clear with 0s because otherwise the resources of K8 will be
> totally messed up.
> It took long to figure it out and here it is:
> res = probe_resource(dev, 0x100 + (reg | link));

Good find!

> This is called with dev = NULL and this is no good for probe_resource at
> all.
> The attached patch fixes the potential problems and of course the problem
> itself. On one particular place was missing test if the device really
> exists.
> This was copied to fam10 and perhaps the same issue is in v3 (DID NOT
> check).
> The rest of the patch is just very paranoid and do all checkings.
> This was tested in SimNOW but I believe it will work on real hw too.
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Acked-by: Myles Watson <mylesgw at gmail.com>

I don't have answers to your questions, but I didn't want that to hold up
the patch.


More information about the coreboot mailing list