[coreboot] [PATCH] fix object/driver confusion ofall northbridge code

[Corey Osgood]

On Tue, Mar 24, 2009 at 12:32 PM, Myles Watson <mylesgw at gmail.com> wrote:

>
>
> > -----Original Message-----
> > From: coreboot-bounces at coreboot.org [mailto:
> coreboot-bounces at coreboot.org]
> > On Behalf Of Peter Stuge
> > Sent: Tuesday, March 24, 2009 10:06 AM
> > To: coreboot at coreboot.org
> > Subject: Re: [coreboot] [PATCH] fix object/driver confusion ofall
> > northbridge code
> >
> > Stefan Reinauer wrote:
> > > Every object file with a struct pci_driver ... __pci_driver needs to
> > > be marked as "driver" instead of "object" in order to get the init
> > > code actually executed.
> > >
> > > This patch fixes up all northbridges that did not do this before.
> > >
> > > Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
> >
> > Acked-by: Peter Stuge <peter at stuge.se>
> >
> > How come we have not noticed this before? Do these NB drivers not do
> > anything critical?
>
> It is hard to believe that the amdk8 northbridge code never got executed.
> Is this only true if it's not contained in a "chip", or if you don't
> specify
> its position in the device tree?


I'm grasping at straws, but I think it had something to do with multiple
drivers in northbridge.c, if it's marked as a driver only the first driver
would get run, or it might have been something to do with the special pci
domain and cpu bus drivers. Then again, I could be entirely wrong, it's been
a while.

-Corey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090324/46c71f53/attachment.html>